Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename benchmark data directory to root directory #574

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Rename benchmark data directory to root directory #574

merged 1 commit into from
Sep 18, 2018

Conversation

danielmitterdorfer
Copy link
Member

With this commit we change the user-facing name of Rally's root
directory for benchmarks from "Benchmark data directory" to "Benchmark
root directory" as the former is implying that we only store data
whereas the latter implies that it can be used for other purposes as
well.

@danielmitterdorfer
Rename benchmark data directory to root directory
483eb30 
With this commit we change the user-facing name of Rally's root
directory for benchmarks from "Benchmark data directory" to "Benchmark
root directory" as the former is implying that we only store data
whereas the latter implies that it can be used for other purposes as
well.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Usability Makes Rally easier to use :Config Config file format changes, new properties, ... labels Sep 18, 2018
@danielmitterdorfer danielmitterdorfer added this to the 1.0.2 milestone Sep 18, 2018
dliappis
dliappis approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope it leads to less confusion in the future.

@danielmitterdorfer danielmitterdorfer merged commit 8e14dd6 into elastic:master Sep 18, 2018
@danielmitterdorfer danielmitterdorfer deleted the benchmark-dir branch September 18, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees
No one assigned
Labels
:Config Config file format changes, new properties, ... enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis